M-x eglot fails to download FsAutoComplete.zip

[Gradi]

Description

Good day. I've installed latest versions of

• eglot
• emacs-fsharp
• eglot-fsharp

and when i open any F# source file and run M-x eglot error pops up saying

eglot-fsharp--maybe-install: Failed to unzip c:/Users/MyUser/AppData/Roaming/.emacs.d/FsAutoComplete/netcore/fsautocomplete.zip

I did some debugging and found out that (on my machine) function eglot-fsharp--maybe-install tries to download file from https://github.com/fsharp/FsAutoComplete/releases/download/v0.50.0/fsautocomplete.netcore.zip url and fails.

Reason for that is that FsAutoComplete has changed something in their deploying process and now version v0.50.0

• doesn't have fsautocomplete.netcore.zip artifact
• versioning scheme changed a bit (title has v letter, but resulting artifact does not). Check screenshoot below

PS. I didn't know where exactly i should have created this issue here or there. Sorry if it's wrong.

Repro steps

1. Install latest version of

   • eglot
   • emacs-fsharp
   • eglot-fsharp

2. Open in valid F# project

3. Run M-x eglot

Expected behavior

Everything works, FsAutoComplete is downloaded and unpacked.

Actual behavior

It fails to download FsAutoComplete.zip

Known workarounds

• Manually download fsautocomplete.0.50.0.nupkg
• Unpack it
• Move tools/net5.0/any/* to ~\.emacs.d\FsAutoComplete\netcore\
• In Emacs set custom variable eglot-fsharp-server-version to "0.50.0" to prevent eglot-fsharp from attempting to download/update FsAutoComplete.zip

Related information

• Windows 10 x64
• Latest version from melpa
• GNU Emacs 27.2 (build 1, x86_64-w64-mingw32) of 2021-03-26
• NET 6.0

[johanvts]

So according to this the long-term solution seems to be to move to using 'dotnet tool' to install fsautocomplete. But I think this would require a rewrite of eglot-fsharp.el

Edit: It seems there is already a PR to make in work with lsp-mode :

https://github.com/emacs-lsp/lsp-mode/pull/3350

[Gradi]

Furthermore, there is pull request that should fix eglot-fsharp.el as well.

[darren-mk]

I think I am still experiencing the same symptom. Even after tried the workaround suggested here.

And Move tools/net5.0/any/* to ~.emacs.d\FsAutoComplete\netcore\ Means to copy all files and folders within "any" to "netcore" folder? If so, that didn't work. Otherwise, can someone explain a little more?

[juergenhoetzel]

Should be fixed by #292