search

fsharp / emacs-fsharp-mode

F# Emacs mode
Apache License 2.0
208 stars 61 forks source link

disable self run mode hooks and let emacs run it #325

Closed augustfengd closed 1 year ago

augustfengd commented 1 year ago

Hello!

The hook is being run twice at the moment. This causes an issue for lsp-mode when we add lsp-deferred to the fsharp-mode-hook and the directory hasn't been added as a workspace yet; lsp-mode will prompt twice for the workspace initialization.

Currently, the workspace initialization is also failing for other reasons, but I've just submitted a PR for that.

Thanks!

juergenhoetzel commented 1 year ago

Good catch! :+1: Merged in 09fec6c: Just removed the extra merge commit.

augustfengd commented 1 year ago

Ya np! I was just about to get rid of it 👍. Thanks ! :)