Broken links on docs homepage

fsharp / fsharp-compiler-docs

Doc build for FSharp.Compiler.Service

https://fsharp.github.io/fsharp-compiler-docs

MIT License

279 stars 123 forks source link

Broken links on docs homepage #970

Closed 0101 closed 1 year ago

0101 commented 2 years ago

Links on docs homepage under Documentation Topics are broken. They point to e.g.

https://fsharp.github.io/fsharp-compiler-docs/overview.md instead of just
https://fsharp.github.io/fsharp-compiler-docs/overview

It should probably be fixed in https://github.com/fsprojects/FSharp.Formatting but we could also just remove the .md suffixes from the docs source. Which will probably work fine everywhere.

baronfel commented 2 years ago

I wonder if this has already been fixed in the FSharp.Formatting tool? I think we're quite behind in this repository at the moment.

nojaf commented 2 years ago

Nope, we put in .html in our Markdown files in the Fantomas repo to overcome this. It still is a problem in fsdocs. Not sure if there already is an issue created for that.

dsyme commented 2 years ago

Should be fixed by https://github.com/fsprojects/FSharp.Formatting/pull/767

Problem seems to have been related to using relative input paths (which is normal) - the testing for link translation in FSharp.Formatting was only testing absolute input paths --input <absolute-path>

nojaf commented 1 year ago

This appears to be fixed.