fsharp / fsharp-core-docs

Generated API documentation for the FSharp.Core library. Generated using FSharp.Formatting.
http://fsharp.github.io/fsharp-core-docs
MIT License
34 stars 19 forks source link

FSharp docs expose pre-release functionality #75

Open MABowser opened 3 years ago

MABowser commented 3 years ago

https://github.com/fsharp/fsharp-core-docs/blob/7d5b8049262e298e6e620ff308ada7999b9a2d81/.github/workflows/docs.yml#L29

My main question is: Is it intentional to have the docs show pre-release functionality?

I was writing a little app and forgot some syntax when using map. I checked the docs and noticed that it exposed a Keys property. I tried to use that instead of what I was doing. After a bit of poking to see if I was somehow missing a namespace I was helped by another engineer who said that Keys is a dotnet 6 feature. I then tried to answer the question "What of this can I use, and what can't I use yet?" which I was unable to do easily.

If this isn't intentional, I could see a number of ways to help:

baronfel commented 3 years ago

I would suggest changing the target branch to the release/dev16.10 branch as the best fix, and then when .net 6 releases move to the release/dev17.0 branch alongside that.

One downside of this is that we do not get quite as up to date feedback as to the documentation status of new features/changed xml documentation, but that's probably acceptable given that these changes aren't deployed to the wider world yet.

dsyme commented 2 years ago

My preference is to not worry about this for now - mainly because of the size of the docs backlogs we have, particularly w.r.t. examples. This is because building off "main" allows us to incorporate latest doc updates for examples - we are restricted in integrating across to release/dev16.0. I tried to convince the dotnet/fsharp folk to have post-hoc updatable docs branches, e.g. docs/main, docs/dev16.0 which we could incorporate into code flow auto merging but didn't convince them partly because of the large number of auto-merge notifications that happen in the repo when you do that.

So my feeling is that we should revisit this once we have completed doc revisions (especially examples) for all of FSharp.Core.

cartermp commented 2 years ago

Yeah, this is not much of a deal IMO. They're usually very little changes in fsharp.core from release to release, and even if there was a substantial change, the vast majority of what people will want to look up is already GA. I would put this near the back of the list of things to solve