search

fsharp / fslang-design

RFCs and docs related to the F# language design process, see https://github.com/fsharp/fslang-suggestions to submit ideas
517 stars 144 forks source link

RFC for triple quoted string interpolation #715

Closed abonie closed 1 year ago

abonie commented 1 year ago

Rendered RFC

dsyme commented 1 year ago

This is looking good!

@abelbraaksma Can I ask you to be primary reviewer on this? When we get a green approve from you I can take a final look. But basically I'm good with the general direction of this, and love how you're helping refine the details.

abelbraaksma commented 1 year ago

@dsyme, sure thing, happy to help! @abonie, just ping me whenever you feel new stuff can be reviewed :).

abonie commented 1 year ago

Hey @abelbraaksma, thanks for the review so far. I have tried to rewrite some sections to make them easier to read and applied your other suggestions too, so whenever you have time for round two, feel free :)

I haven't covered why we are not doing any of the alternatives, but I hope to have some discussion about that first - perhaps more exploration is needed.

abelbraaksma commented 1 year ago

@dsyme, this is ready, can review and/or merge?

dsyme commented 1 year ago

Really great work, thank you!