search

fsharp / zarchive-vim-fsharp

F# bindings for vim
MIT License
143 stars 34 forks source link

Match build.fsx to Makefile #7 #8

Closed panesofglass closed 9 years ago

forki commented 9 years ago

If you keep using nuget then you should keep the restorepackages phase in the build script

panesofglass commented 9 years ago

NuGet is only needed to fetch FAKE from install.cmd.

forki commented 9 years ago

Then it should be easy to switch to paket bootstrapper ;-) On May 23, 2015 09:15, "Ryan Riley" notifications@github.com wrote:

NuGet is only needed to fetch FAKE from install.cmd.

— Reply to this email directly or view it on GitHub https://github.com/fsharp/vim-fsharp/pull/8#issuecomment-104856030.

rneatherway commented 9 years ago

I would definitely switch to Paket. The nuget usage and path ../lib/nuget/nuget.exe is from when this was a subdirectory in the fsharpbinding repository. I think there is no need to stick with nuget now.

panesofglass commented 9 years ago

I'll add that later today!

panesofglass commented 9 years ago

I actually thought about switching to powershell, as that would not require us to download any other tools. Thoughts?

panesofglass commented 9 years ago

Hmm, though I suppose FAKE + Paket would be sufficient for a single "build" script.

rneatherway commented 9 years ago

If you are thinking of removing the Makefile and just using Paket/FAKE then there could just be a single build script, which is better than having two probably. As I said on #7 the benefit of using Make is that it handles dependencies better than FAKE (which doesn't avoid recompilation or patterns like .el -> .elc unless I'm mistaken), but if that isn't needed and the Makefile is just a glorified shell script then it seems reasonable to use FAKE.

rneatherway commented 9 years ago

(But @kjnilsson would know best for this repo)

panesofglass commented 9 years ago

I won't remove the Makefile; I will just add a build.sh.

panesofglass commented 9 years ago

Honestly, bash and powershell are probably sufficient.

panesofglass commented 9 years ago

FWIW, I'm happy to remove the PowerShell attempt. I thought that might be simple, but I'm no PowerShell expert. Perhaps @ctaggart or some other PS whiz could help if there's interest.

panesofglass commented 9 years ago

Please note, while I added install.sh, I have not tested it on nix. I tried it in Git Bash, and it fails b/c of WebClient.DownloadFile, so it may not work on nix.

rojepp commented 9 years ago

In sublime, I let paket handle the downloading of FSAC, I thought it was neat. :) https://github.com/fsharp/sublime-fsharp-package/pull/5 Still have to unzip it though.