Enhanced README, Enhanced promiseFiles, Added options.shortName='relative'

fshost / node-dir

Recursive asynchronous file and directory operations for Node.js

MIT License

221 stars 44 forks source link

Enhanced README, Enhanced promiseFiles, Added options.shortName='relative' #43

Open AckerApple opened 7 years ago

AckerApple commented 7 years ago

The README is far more functional and lends itself to greater explanations.
promiseFiles now can have just options and type will default to 'file'
options.shortName='relative' is now available and far more applicable than shortName=true

Thank you kindly!

AckerApple commented 7 years ago

Additional tests have also been included

AckerApple commented 7 years ago

Let me know if I can help any further. Looking for action on this so I might use node-dir from NPM.

Do hope this time of year is a pleasant one for you and those around you. Working hard myself but looking forward to putting down the keyboard for the very close of this year.

jharmn commented 7 years ago

+1 for a quick npm publish...we're linking to the latest commits in our package.json to get the promises :)

AckerApple commented 7 years ago

@fshost, hope all is well. Anyway that we can help get this pull request accepted and added to npm?

We've had to build training documentation on using node-dir but pulling code from my fork: https://github.com/AckerApple/node-dir

Please help make life easier for everyone, please accept this pull request.

fshost commented 7 years ago

Sorry for taking so long. I've been really tied up with stuff that pays the bills. I need to resolve this and test it. I hope I can get it done soon. Thanks for your patience.

AckerApple commented 7 years ago

I have merged the conflicts to the best of my ability and then tested.

Lets keep this ball rolling in motion.

And hey, I know what you mean by "stuff that pays the bills" but I'm trying to pay the bills using your package. So do help me out, lets get this pull request released to npm.

AckerApple commented 7 years ago

My pull request has 153 Clones, 96 Unique cloners. People are using it.

On npm, node-dir had 855,558 downloads in the last month. Your face is getting seen on the NPM page.

Please help me, help you, publish this pull request. I have my own NPM packages, that have the dependency as this pull request, I really want to fix that. I really really really don't want to republish my pull request as a different named package, no reason to have two packages doing the same thing. Plus you have a better looking face for NPM visitors to see and we should keep it that way.

Please, in the most kindest way, pull and npm publish. Thank you much.

AckerApple commented 7 years ago

@mlcdf, thanks. I can't believe I'm still running off this fork. I need to republish to npm.

@fshost, hope all is well man. You've been MIA long time. Please pull my fork and "npm publish" but I'm pretty set on npm publishing my fork under different name.

AckerApple commented 7 years ago

Added Windows testing via ci.appveyor.com . Upgraded Travis to test more versions of node.

AckerApple commented 7 years ago

Ignore code of conduct commits

AckerApple commented 7 years ago

We miss you @fshost ! But we've moved on. My fork of node-dir has been renamed to path-reader and published to npm. We do hope all is well otherwise.

https://www.npmjs.com/package/path-reader