fsinfuhh / Bitpoll

A web application for scheduling meetings and general polling.
GNU General Public License v3.0
245 stars 38 forks source link

OpenId Connect integration #147

Closed timonegk closed 8 months ago

Akasch commented 9 months ago

I see caching for the Auth-Tokens: is it checked to revoke the tokens if the user changes his password or perform a logout on the central SSO?

ftsell commented 9 months ago

I see caching for the Auth-Tokens: is it checked to revoke the tokens if the user changes his password or perform a logout on the central SSO?

Those are tokens not issued for a user but to the application itself (sometimes its called service account authentication). There is no user involved who can change their password.

Akasch commented 9 months ago

I haven't looked into it, but i quit often see that a logout on the central SSO platform or a password change there does not invalidate active sessions in the applications that have an ongoing session for the user. This leads to the problem if the User has the password stolen and the attacker was authenticated he can not invalidate existing sessions.

timonegk commented 9 months ago

As Finn said, the caching here is only about bitpoll's token required to request the users in a group.

However, your point about SSO login is probably still valid. @ftsell do you know how we handle that or if we should change something in the simple_openid_connect library to make sure that a token is still valid?

ftsell commented 9 months ago

However, your point about SSO login is probably still valid. @ftsell do you know how we handle that or if we should change something in the simple_openid_connect library to make sure that a token is still valid?

Hmm good question :thinking: I haven't verified this extensively but what I think is happening is that the mechanism here is two-fold: