search

fsingletonthorn / EffectSizeScraping

MIT License
1 stars 0 forks source link

Replace home spun text cleaning functions with replace_non_ascii() from text clean package for consistency? #26

Closed fsingletonthorn closed 5 years ago

fsingletonthorn commented 5 years ago

Need to check it doesn't break anything / remove or replace Greek letters in a way that might lead to problems before switching over - I have added this to the dependencies list already, remove if we don't end up using it

fsingletonthorn commented 5 years ago

Also could look at using their htmltag remover - just have to look at whether they definitly do not remove things between <> unless they are html tags (this happened in an older version of this package and led to "P < .05, p > .05" becoming "P .05"

fsingletonthorn commented 5 years ago

Closing for now as the current ones seem to work fairly well