search

fsiwi-hka / iwi-website

This repository contains the website of the Fachschaft IWI at the University of Applied Sciences Karlsruhe (HKA).
https://iwi-hka.de
MIT License
4 stars 9 forks source link

fix: switch icons footer #123

Closed daniel-vera-g closed 2 years ago

daniel-vera-g commented 2 years ago

https://fachschaftiwi.slack.com/archives/C01581R00SW/p1638871427002800

daniel-vera-g commented 2 years ago

Noch ne Anmerkung zur package-lock:

Die Änderung von Version 1 -> 2 ist Rückwärtskompatibel. Wenn Ihr jedoch eine version von npm < 7 habt, bekommt Ihr wahrscheinlich eine Warnung beim Installieren die aber kein Problem sein sollte.

Da es aber keine weiteren Probleme bereiten sollte, könnten wir es bei der v2 lassen. Außer jemand der npm < v7 hat stört sich mega arg an der Meldung.

cc.. @jwestenhoff dem es aufgefallen ist 😄

mapelpapel commented 2 years ago

Got this error:

error - ./components/common/footer.tsx:9:0
Module not found: Can't resolve 'react-obfuscate'
   7 | import { faEnvelope } from '@fortawesome/free-solid-svg-icons'
   8 | import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
>  9 | import Obfuscate from 'react-obfuscate'
daniel-vera-g commented 2 years ago

Got this error:

error - ./components/common/footer.tsx:9:0
Module not found: Can't resolve 'react-obfuscate'
   7 | import { faEnvelope } from '@fortawesome/free-solid-svg-icons'
   8 | import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
>  9 | import Obfuscate from 'react-obfuscate'

Did you try npm install (from my Feature branch fix/footer-links ) @mapelpapel ? I added this dependency and you probably do not have it installed.

mapelpapel commented 2 years ago

Got this error:

error - ./components/common/footer.tsx:9:0
Module not found: Can't resolve 'react-obfuscate'
   7 | import { faEnvelope } from '@fortawesome/free-solid-svg-icons'
   8 | import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
>  9 | import Obfuscate from 'react-obfuscate'

Did you try npm install (from my Feature branch fix/footer-links ) @mapelpapel ? I added this dependency and you probably do not have it installed.

Yep, that fixed the issue. Shouldn't have ignored the IDE pop-up 😂