search

fskpf / svg2roughjs

Create sketchy, hand-drawn-like images from SVGs
https://fskpf.github.io/
MIT License
158 stars 13 forks source link

Polylines should honor fill #18

Closed ygra closed 4 years ago

ygra commented 4 years ago

This raises an interesting question about auto-stroking filled but unstroked shapes. This could happen here as well and may not like intended (since one line is missing). Perhaps doing the auto-stroke only on closed shapes (rect, circle, ellipse, polygon)? What about paths? Analyze every sub-path whether it's closed or not and perhaps split them based on that?

fskpf commented 4 years ago

I'd say doing it on only closed shapes works well for now. The paths could wait until it bugs us enough to do it properly.