Code editor doesn't update rendering when backspace is pressed

fskpf / svg2roughjs

Create sketchy, hand-drawn-like images from SVGs

https://fskpf.github.io/

MIT License

158 stars 13 forks source link

Code editor doesn't update rendering when backspace is pressed #43

Closed ygra closed 4 years ago

fskpf commented 4 years ago

Part of the commit is for #32. However, the change <-> inputRead is still a problem, because of triggering an unnecessary drawing when loading a file. The code-mirror states that inputRead should be user input changes. Sucks that backspace doesn't trigger it.

I think keyup should work best here.

ygra commented 4 years ago

Ah, sorry for that, then. inputRead is strictly for text input, i.e. a key that produces a character (or IME input). So backspace, since it has no character, doesn't trigger it, annoyingly.