fskpf / svg2roughjs

Create sketchy, hand-drawn-like images from SVGs
https://fskpf.github.io/
MIT License
158 stars 13 forks source link

Path rendered with fill despite having none #68

Closed ygra closed 3 years ago

ygra commented 3 years ago

Can be seen with https://commons.wikimedia.org/wiki/File:Clock_group.svg

The path that renders the 3/6/9/12 hour ticks is drawn with a fill which isn't how it appears in the original image:

image

Original:

image

ygra commented 3 years ago

The path itself is just two lines (M ... L ... M ... L ...), but inside a symbol that's instantiated with a use. Perhaps that changes how it's rendered. It shouldn't have any area to fill, though, even though the path itself has an unset fill and thus should appear black.

Perhaps an issue with rough.js instead of our code, though. Could be circumvented by drawing two separate paths split on the move command in the middle.

fskpf commented 3 years ago

This is the same issue as #71. Disabling combineNestedSvgPaths would also resolve the attached SVG here. Therefore I'll close this issue as duplicate of #71.