search

fsktom / rusty-endsong-parser

Better, more performant version of https://github.com/fsktom/endsong-parser-python written in Rust
0 stars 0 forks source link

Rename all Duration to TimeDelta #76

Closed fsktom closed 3 months ago

fsktom commented 6 months ago

In chrono (currently, 0.4.35) Duration is just a type alias for TimeDelta (see https://github.com/chronotope/chrono/pull/1137#issuecomment-1627782392)

I think it'd be better if I use the actual struct name instead of its alias (also to differentiate it from std's Duration)

fsktom commented 3 months ago

https://docs.rs/chrono/0.4.38/chrono/index.html#time-delta--duration

The TimeDelta type was previously named Duration (and is still available as a type alias with that name). A notable difference with the similar core::time::Duration is that it is a signed value instead of unsigned.