search

fslaborg / Deedle

Easy to use .NET library for data and time series manipulation and for scientific programming
http://fslab.org/Deedle/
BSD 2-Clause "Simplified" License
933 stars 195 forks source link

Do not run the documentation generation tests on Mono #280

Closed dsyme closed 9 years ago

dsyme commented 9 years ago

Documentation is generated on Windows. Running the documentation generation tests looks a little fragile on Mono.

dsyme commented 9 years ago

See #278

dsyme commented 9 years ago

Closed in favour of this https://github.com/BlueMountainCapital/Deedle/pull/282

tpetricek commented 9 years ago

Thanks for looking into the range issue - that was the problem!

I'm still not sure what to do about the documentation tests. I would like to keep those enabled (or at least disable the specific one if we know what is causing it). It is good to keep them as part of the continuous build and we should fix them on Mono in the future anyway!

The problem seems to be that F# Interactive (run via F# Formatting) fails to find FSharp.Data.dll. It does not complain on the #r line, but only when types from the assembly would be actually called. I think I've seen similar behavior on Windows, but it is a bit puzzling! Any thoughts are welcome....

tpetricek commented 9 years ago

Oh, right, so having:

#load "../../bin/Deedle.fsx"
#I "../../packages/FSharp.Data.2.0.14/lib/net40"
#r "FSharp.Data.dll"

...does not work, but having:

#I "../../packages/FSharp.Data.2.0.14/lib/net40"
#r "FSharp.Data.dll"
#load "../../bin/Deedle.fsx"

does. Not sure why - but I guess the FSI starts looking for FSharp.Data.dll already when loading Deedle.dll (as it is referenced) and because that is before we specify the path, it fails?