search

fslaborg / Deedle

Easy to use .NET library for data and time series manipulation and for scientific programming
http://fslab.org/Deedle/
BSD 2-Clause "Simplified" License
929 stars 196 forks source link

Expand public fields #313

Closed tpetricek closed 8 years ago

tpetricek commented 9 years ago

Although this is not the most common scenario, there are some nice libraries that expose data as public (readonly) fields. This PR adds support for reading frame columns from public fields (this does not affect normal .NET classes with private fields).

[This is adding just one commit to the existing PR - so we need to merge that one first]

tpetricek commented 9 years ago

I updated this PR to match the latest version.

@hmansell @adamklein Would anybody object to merging this? (It is a fairly innocent change that just enables one more scenario that I came across. I think it does not realistically affect any existing code, because public fields are not very frequent - the only F# type I can think of is ref<'T>).

tpetricek commented 9 years ago

The build completed successfully but then failed when shutting down. Travis sometimes does that :-(

adamklein commented 9 years ago

Looks good, nice scenario to support.