search

fslaborg / Deedle

Easy to use .NET library for data and time series manipulation and for scientific programming
http://fslab.org/Deedle/
BSD 2-Clause "Simplified" License
929 stars 196 forks source link

Make ChunkSizeInto behave according to documentation #314

Closed buybackoff closed 8 years ago

buybackoff commented 9 years ago

Make ChunkSizeInto behave according to the documentation with regards to the key for Boundary.AtBeginning is the last key. This is needed for overlapped windows build by ChunkSizeInto with size X and then by moving window on the chunks with widths Y and merging chunks inside each window. The result is overlapped windows with widths X*Y and step X. With current behavior, the key for each overlapped window is the first key of the last inner chunk, i.e. _ _ ._ not _ _ _. . if we have 3 inner chunks.

buybackoff commented 9 years ago

The only one of the #306 issues that makes me keep local build for a while, unless it is merged.

tpetricek commented 9 years ago

Sorry for the delay here. I wanted to merge the big #302 PR first.

This change looks good to me (and I think the behavior you implement is more reasonable than the one we had before). But it would be changing behavior, so I'll let @hmansell and @adamklein review this too (I'd be up for merging this).

Can you write a brief comment saying which exactly functions & in what exact situations are affected? (If I'm correct it's only chunkSizeInto called with Boundary.AtBeginning).

buybackoff commented 9 years ago

You are correct, I only changed chunkSizeInto, but chunkSize calls it.

adamklein commented 9 years ago

This should be safe to merge from our perspective.