Fix RowsDense (broken by BigDeedle changes)

fslaborg / Deedle

Easy to use .NET library for data and time series manipulation and for scientific programming

http://fslab.org/Deedle/

BSD 2-Clause "Simplified" License

929 stars 196 forks source link

Fix RowsDense (broken by BigDeedle changes) #319

Closed tpetricek closed 8 years ago

tpetricek commented 8 years ago

Some of the BigDeedle changes broke the RowsDense operation.

The previous implementation was a bit odd - I'm not sure why I thought that creating an empty series is a good idea! This is a simpler implementation using df.Rows (for BigDeedle, the call to dropMissing will materialize the frame).

EDIT: I added one more commit - I accidentally also broke the dropSparse functions.

tpetricek commented 8 years ago

@adamklein @hmansell Can I ask you for a quick review of this change?

The change restores the original behavior:

"rows dense" returns only rows that have all values
"drop sparse" drops all rows that have any missing (i.e. the same thing as above)

The fact that I got these wrong only suggests that this is another part of the API that should be improved in "version 2", but the current changes are fairly minimal.

adamklein commented 8 years ago

Looks good to me!