search

fslaborg / Deedle

Easy to use .NET library for data and time series manipulation and for scientific programming
http://fslab.org/Deedle/
BSD 2-Clause "Simplified" License
929 stars 196 forks source link

Frame.SaveCsv bad default argument #325

Closed ygrodentzik closed 4 years ago

ygrodentzik commented 8 years ago

In C#, Frame.SaveCsv defaults the argument, includeRowKeys, to false. This should be true.

adamklein commented 8 years ago

@ygrodentzik To clarify, I believe you're suggesting this be the default since it's the most common use case (rather than this being an actual bug). I'm ok with this, curious what @tpetricek thinks, doesn't seem like it would cause any big compatibility issues.

tpetricek commented 8 years ago

Including row keys sounds like a better default. I'd be happy to change that.