Recover documentation test

fslaborg / Deedle

Easy to use .NET library for data and time series manipulation and for scientific programming

http://fslab.org/Deedle/

BSD 2-Clause "Simplified" License

924 stars 196 forks source link

Recover documentation test #387

Closed tpetricek closed 5 years ago

tpetricek commented 6 years ago

I think the PR #386 by @zyzhu disabled the documentation tests to get things to work. It would be nice to re-enable this at some point.

zyzhu commented 6 years ago

I commented them out as the old documents tests has the following errors. For instance. ./frame.fsx (1:0-957:13): Error - An implementation of the file or module 'Frame$fsx' has already been given

Do you know anything about this error? I saw a similar error in Fable issues related to diamond dependencies. https://github.com/fable-compiler/Fable/issues/639

zyzhu commented 5 years ago

@tpetricek I've recovered the documentation tests by working around the above error. Do you think it is ok? https://github.com/fslaborg/Deedle/pull/390