fslaborg / Deedle

Easy to use .NET library for data and time series manipulation and for scientific programming
http://fslab.org/Deedle/
BSD 2-Clause "Simplified" License
924 stars 196 forks source link

Target netstandard2.0 #391

Closed zyzhu closed 5 years ago

zyzhu commented 5 years ago

Various changes based on the initial efforts of @kblohm. Both Deedle and Deedle.RProvider compiles targeting dotnet standard now.

zyzhu commented 5 years ago

Trigger travis build.

dsyme commented 5 years ago

THis is great work. @kblohm Could you do a post-hoc review? thanks

kblohm commented 5 years ago

Sure i can. Just a few minor notes:

zyzhu commented 5 years ago

@kblohm Thanks for your review. I've done a pull request to address some problems. Please take a look and let me know what you think. https://github.com/fslaborg/Deedle/pull/393

    • All Deedle tests target netcoreapp2.1 and net45
    • RPlugin.tests target net45
    • Documentation.tests target net461 because of fsharp.formatting
  1. I don't know how to force locale of error messages to en-us. I've tried some tricks but didn't succeed. Maybe a short-term solution is to turn off documentation test on your local machine so that build can pass.
    • RPlugin.Tests is really a pain. My environment has R-3.4.3 (with zoo package installed) installed at C:\R\R-3.4.3\bin\x64. I add this to path environment variable. I also set R_HOME to be C:\R\R-3.4.3. With those environment settings, RPlugin.Tests shall be able to build.
    • But in order to run RPlugin.Tests, I couldn't get it working via dotnet test as it always look for x86 version of R by default. For now, I enforced RPlugin.Tests to be run via nunit.consolerunner.
    • I also changed the default setting in build.fsx. By default it will only build allcore which exclude rplugin and rplugin tests so that we can focus on Deedle itself until the picture of RProvider is clearer.
  2. I did remove netstandard from Deedle.RPlugin. We shall keep it at net45 until RProvider is on netstandard.