Closed kblohm closed 5 years ago
@kblohm Amazing work! I was struggling to learn all the changes of FAKE 5. Thanks for getting this done.
One pending issue is Deedle.RPlugin.Tests. dotnet test keeps looking for R 32bit version and failed. I used to have nunit.console run it, but it somehow failed now as well.
I'll merge this for now and comment Deedle.RPlugin.Tests out to run locally until we find a solution for it.
Would you mind redeploying the docs to https://fslab.org/Deedle/ ? The API documentation is missing there because it was not generated before. As for the RTests: what is the error you are getting? And are you on windows?
I have just deployed the docs. Let me know if you find any problem.
The following is the error when I ran dotnet test under Deedle.RPlugin.Tests. It's looking for 32bit of R instead of 64bit of R. But 64bit dotnet cli was installed. I don't know how to force it to find 64bit of R. Running Deedle.RPlugin.Tests test cases in FSI under Visual Studio has no problem.
Failed Can get the result of R.cor as a Deedle frame (#212) Error Message: System.Exception : Initialization of R.NET failed ----> System.Exception : This 32-bit process failed to load the library C:\R\R-3.4.3\bin\i386\R.dll. Native error message is '%1 is not a valid Win32 application'
Is it on purpose that fake.sh
does not have execute permissions on Linux?
No. That is just me being on windows. I made a PR to set the flag. #425
The doc-generation is kind of ugly because FSFormatting is not netstandard yet and i cant use the FSFormatting.exe because deedle uses a custom fsiEvaluator. But that was not too pretty before, so i think its ok for now.
I hope this builds on linux, i could not test that.