search

fslaborg / Deedle

Easy to use .NET library for data and time series manipulation and for scientific programming
http://fslab.org/Deedle/
BSD 2-Clause "Simplified" License
937 stars 195 forks source link

Move to dotnet sdk 3.0 and use dotnet-paket #489

Closed eiriktsarpalis closed 4 years ago

eiriktsarpalis commented 4 years ago

I was having trouble building the repo locally, so I updated the repo to make use of dotnet sdk 3.0 tools for paket and fake.

zyzhu commented 4 years ago

Thanks! Could you take a look why documentation test failed to build?

eiriktsarpalis commented 4 years ago

I've opened up a deep rabbit hole here. I give up.

zyzhu commented 4 years ago

@eiriktsarpalis Thanks for trying.

I've given it a spin. You are just one step away. https://github.com/zyzhu/Deedle/commits/pr/489-move-to-dotnet-sdk-3-0-and-use-dotnet-paket Change /../lib/mono/4.7.1-api/ to /../lib/mono/4.6.1-api/ and then documentation tests are passed on everything except osx on Azure DevOps.

We can remove that vmimage as osx has been tested on Travis already. Could you change that and try this pull again?

eiriktsarpalis commented 4 years ago

That seems to have done the trick. Thanks for the tip!