search

fslaborg / Deedle

Easy to use .NET library for data and time series manipulation and for scientific programming
http://fslab.org/Deedle/
BSD 2-Clause "Simplified" License
937 stars 195 forks source link

Fix two csv issues #494

Closed zyzhu closed 4 years ago

zyzhu commented 4 years ago

Fix #479 and #441

I overrides two places in csvinference.fs from FSharp.Data/

  1. The code to separate column name by \n is for type provider's field name inference. It serves no purpose in Deedle's CSV scenario. https://github.com/fsharp/FSharp.Data/blob/master/src/Csv/CsvInference.fs#L308
  2. The pull request to change the inference of empty cell is still pending in FSharp.Data repo. It should be fine to change here first as it passed all unit tests. https://github.com/fsharp/FSharp.Data/issues/1192