search

fslaborg / Deedle

Easy to use .NET library for data and time series manipulation and for scientific programming
http://fslab.org/Deedle/
BSD 2-Clause "Simplified" License
924 stars 196 forks source link

Signature of Matrix.dot is unnecessarily limited #536

Closed brianberns closed 2 years ago

brianberns commented 2 years ago

The current signature of Matrix.dot for two frames is:

df1:Frame<'R, 'C> * df2:Frame<'C, 'R> -> Frame<'R,'R>

But why do the 'R types have to match? This seems to be more flexible and make more sense:

df1:Frame<'R0, 'C> * df2:Frame<'C, 'R1> -> Frame<'R0,'R1>
zyzhu commented 2 years ago

That's a good point. I've fixed it here https://github.com/fslaborg/Deedle/commit/e1e1a0c9408a924f936eb39a6bb1d5234daacd42 and released Deedle.Math 2.4.2.

brianberns commented 2 years ago

Thanks for making this change, but it looks like Deedle.Math 2.4.2 refers to Deedle 2.4.2, which hasn't been released yet. Is that on the way as well?

zyzhu commented 2 years ago

They should be on Nuget now.