DavideGCosta commented 3 years ago

This is a code to fix the issue https://github.com/fslaborg/FSharp.Stats/issues/142.

Added a length check to Pearson.
Made spearman use averageRanks.
Made spearman generic.
Add spearman tests.

Let me know if you want me to make any changes.

nhirschey commented 3 years ago

This looks good to me. @DavideGCosta helped me with this and I have inspected the code.

codecov-commenter commented 3 years ago

Codecov Report

Merging #144 (c18863c) into developer (3ab7939) will increase coverage by 0.34%. The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           developer     #144      +/-   ##
=============================================
+ Coverage      27.97%   28.32%   +0.34%     
=============================================
  Files            112      112              
  Lines          11946    11966      +20     
  Branches        2534     2546      +12     
=============================================
+ Hits            3342     3389      +47     
- Misses          8422     8469      +47     
+ Partials         182      108      -74

Impacted Files	Coverage Δ
src/FSharp.Stats/Correlation.fs	`2.33% <0.00%> (-0.59%)`	:arrow_down:
tests/FSharp.Stats.Tests/Correlation.fs	`90.24% <ø> (-9.76%)`	:arrow_down:
src/FSharp.Stats/Seq.fs	`0.59% <0.00%> (ø)`
src/FSharp.Stats/List.fs	`7.14% <0.00%> (ø)`
src/FSharp.Stats/Array.fs	`2.58% <0.00%> (ø)`
src/FSharp.Stats/Vector.fs	`11.73% <0.00%> (ø)`
src/FSharp.Stats/Intervals.fs	`1.38% <0.00%> (ø)`
src/FSharp.Stats/Permutation.fs	`26.92% <0.00%> (ø)`
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ab7939...c18863c. Read the comment docs.

bvenn commented 3 years ago

Great, thanks @DavideGCosta and @nhirschey for contribution and fixing this issue 🚀

fslaborg / FSharp.Stats

Fix spearman and add tests #144

Codecov Report