fslaborg / FSharp.Stats

statistical testing, linear algebra, machine learning, fitting and signal processing in F#
https://fslab.org/FSharp.Stats/
Other
210 stars 56 forks source link

[Feature Request] Move distance metrics from the ML module to Linear Algebra #200

Closed Recktenwald closed 2 years ago

Recktenwald commented 2 years ago

Is your feature request related to a problem? Please describe. Since F# enforces strict linearity, the distance metrics are only usable in the ML module and the ones after it in the .fsproj file. In particular, they are not usable in the optimization module, I am currently working on.

Describe the solution you'd like Put the distance in the linear algebra module. For code that already uses the distance metrics, this would break backward compatibility. I.e. someone calling ML.DistanceMetrics.euclidean would find their code no longer working

muehlhaus commented 2 years ago

I think we should move "DistanceMetrics" into the Core module. This makes it usable everywhere and would be a better place anyway. We can reference it in the ML module and deprecate it there... This should fix the problems

bvenn commented 2 years ago

I would also prefer moving DistanceMetrics into core, right beneath Correlation. @Recktenwald, shall I make the changes or do you want to do it along with the optimization PR?

Recktenwald commented 2 years ago

You can go ahead and just make the change right now, I think it will take some time until I will do the PR.

bvenn commented 2 years ago

closed by 4f4e08b440c7122f3ac39fd4cd014796560369cd