fslaborg / FSharp.Stats

statistical testing, linear algebra, machine learning, fitting and signal processing in F#
https://fslab.org/FSharp.Stats/
Other
205 stars 54 forks source link

interpolation test #201

Closed AndyAbok closed 2 years ago

AndyAbok commented 2 years ago

Thank you for contributing to FSharp.Stats. Please take the time to tell us a bit more about your PR.

Please reference the issue(s) this PR is related to

Note: If this PR does not relate to an issue, please create one before submitting it.

Use one of the closing keywords if your PR resolves the related issue e.g.:

Description Adding more unit test for interpolation models - polynomial

[Required] please make sure you checked that

[Optional]

bvenn commented 2 years ago

There are some problems with this PR:

  1. Your test is failing because the accuracy of the implemented interpolation is higher than your expectation. If you replace the expected value with -0.1894337636 the test succeeds.
  2. Please always check whether the tests fail by calling ./build.cmd runtests.
  3. When adding tests add special cases (e.g. values beeing 0, negative, nan ...)
  4. Please open a new test list with testList "Interpolation.Polynomial" [...] because at the moment it is in the cubicSpline test list
AndyAbok commented 2 years ago

Okay I have taken note of the comments. Thanks I'll review them.

bvenn commented 2 years ago

@AndyAbok, I added tests for the polynomial coefficients and opened a separate test that was referenced in Main.fs.