Closed fejung closed 2 years ago
- the function min3 only works with integers, but currently accepts every form of input. Added: type annotation int behind the function parameters removed inline
The function should've worked for any input of type 'IComparable but as this function is private and only utilized as int-comparison helper, it doesn't matter at this position.
Merging #210 (261b0b8) into developer (262f1ac) will increase coverage by
1.91%
. The diff coverage is96.28%
.
@@ Coverage Diff @@
## developer #210 +/- ##
=============================================
+ Coverage 31.61% 33.53% +1.91%
=============================================
Files 124 125 +1
Lines 11664 11924 +260
Branches 1784 1785 +1
=============================================
+ Hits 3688 3999 +311
+ Misses 7535 7480 -55
- Partials 441 445 +4
Impacted Files | Coverage Δ | |
---|---|---|
src/FSharp.Stats/DistanceMetrics.fs | 46.08% <0.00%> (+46.08%) |
:arrow_up: |
tests/FSharp.Stats.Tests/Main.fs | 0.00% <0.00%> (ø) |
|
tests/FSharp.Stats.Tests/DistanceMetrics.fs | 100.00% <100.00%> (ø) |
|
src/FSharp.Stats/Fitting/Spline.fs | 91.17% <0.00%> (-0.26%) |
:arrow_down: |
src/FSharp.Stats/Array.fs | 0.00% <0.00%> (ø) |
|
...tats/ML/Unsupervised/PrincipalComponentAnalysis.fs | 0.00% <0.00%> (ø) |
|
src/FSharp.Stats/Ops.fs | 4.00% <0.00%> (+0.15%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 262f1ac...261b0b8. Read the comment docs.
Changes to the distance metrics scirpt:
Added unit tests for the functions in the distance metrics script:
Added the respective lines to run the tests to the main.fs script in the tests folder