codecov-commenter
commented
12 months ago Codecov Report
Merging #272 (1ac1d12) into developer (c7aab2e) will increase coverage by
0.00%. The diff coverage is38.46%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## developer #272 +/- ##
==========================================
Coverage 48.22% 48.22%
==========================================
Files 151 151
Lines 15581 15580 -1
Branches 2020 2020
==========================================
Hits 7514 7514
+ Misses 7494 7493 -1
Partials 573 573 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/FSharp.Stats/Fitting/GoodnessOfFit.fs | 0.00% <0.00%> (ø) |
|
| src/FSharp.Stats/Fitting/LinearRegression.fs | 4.28% <0.00%> (ø) |
|
| src/FSharp.Stats/Fitting/NonLinearRegression.fs | 16.37% <0.00%> (ø) |
|
| src/FSharp.Stats/Interpolation/Approximation.fs | 0.00% <0.00%> (ø) |
|
| src/FSharp.Stats/Interpolation/Polynomial.fs | 31.25% <0.00%> (ø) |
|
| ...Sharp.Stats/ML/Unsupervised/IterativeClustering.fs | 0.00% <0.00%> (ø) |
|
| src/FSharp.Stats/Quantile.fs | 31.29% <0.00%> (ø) |
|
| src/FSharp.Stats/Testing/PostHoc.fs | 22.09% <0.00%> (ø) |
|
| src/FSharp.Stats/DistanceMetrics.fs | 46.08% <60.00%> (ø) |
|
| ...tats/ML/Unsupervised/PrincipalComponentAnalysis.fs | 100.00% <100.00%> (ø) |
|
| ... and 2 more |
Notes:
FSharp.Stats.Testing.SAM, the current implementation only checks for positive infinity, just wondering if this is an overlook (sorry, not familiar with the underlying domain concepts), might be worth a comment if it is not
such a refactor will help with https://github.com/fable-compiler/Fable/issues/3489
[ ] The project builds without problems on your machine
[ ] Added unit tests regarding the added features
For first point, I had to tweak
INormFloat<bignum>interface implementation in Numeric.fs, as it didn't compile in my environment (I think the implementation is plain wrong).For the second point, this is a refactoring not supposed to add any APIs nor to change any results, all the tests are passing.
Related: https://github.com/fable-compiler/Fable/issues/3489