This pull request addresses the issues encountered in the FSharp.Stats library related to matrix manipulation, specifically in the SpecializedGenericImpl.setColM function and associated tests.
Changes Made:
Corrected the validation check in the setColM function to properly utilize row counts instead of column counts. This ensures correct behavior, especially with non-square matrices.
Updated the tests in the Matrix.fs file to include scenarios for non-square matrices and utilize Matrix.setCol instead of Matrix.setRow for consistency.
Testing:
Ran existing test suite to ensure that existing functionality is maintained.
Added new test case to cover scenarios with non-square matrices and verified correct behavior of the setCol function.
Description:
This pull request addresses the issues encountered in the
FSharp.Statslibrary related to matrix manipulation, specifically in theSpecializedGenericImpl.setColMfunction and associated tests.Changes Made:
Corrected the validation check in the
setColMfunction to properly utilize row counts instead of column counts. This ensures correct behavior, especially with non-square matrices.Updated the tests in the
Matrix.fsfile to include scenarios for non-square matrices and utilizeMatrix.setColinstead ofMatrix.setRowfor consistency.Testing:
setColfunction.Related Issues: