fslaborg / FSharp.Stats

statistical testing, linear algebra, machine learning, fitting and signal processing in F#
https://fslab.org/FSharp.Stats/
Other
205 stars 54 forks source link

remove AutoOpen on Seq, List and Array modules, define RequireQualifiedAccess on them. #320

Closed smoothdeveloper closed 3 months ago

smoothdeveloper commented 3 months ago

Closes #312

Description

There are few shenanigans with FSharp.Stats.DistanceMetrics.Vector and FSharp.Stats.DistanceMetrics which needs to be open in a non intuitive order, please let me know if you prefer I rejig this in some way.

I think one approach would be to put RequireQualifiedAccess for the Vector module, but would incur more impact in client code.

https://learn.microsoft.com/en-us/dotnet/fsharp/style-guide/component-design-guidelines#consider-using-requirequalifiedaccess-and-carefully-apply-autoopen-attributes

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 95.83333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 47.61%. Comparing base (557ee8a) to head (73ee371). Report is 2 commits behind head on developer.

Files Patch % Lines
src/FSharp.Stats/Correlation.fs 0.00% 2 Missing :warning:
src/FSharp.Stats/Vector.fs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## developer #320 +/- ## ============================================= + Coverage 47.56% 47.61% +0.05% ============================================= Files 151 152 +1 Lines 16726 16765 +39 Branches 2253 2253 ============================================= + Hits 7956 7983 +27 - Misses 8082 8097 +15 + Partials 688 685 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.