Closed smoothdeveloper closed 3 months ago
Attention: Patch coverage is 95.83333%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 47.61%. Comparing base (
557ee8a
) to head (73ee371
). Report is 2 commits behind head on developer.
Files | Patch % | Lines |
---|---|---|
src/FSharp.Stats/Correlation.fs | 0.00% | 2 Missing :warning: |
src/FSharp.Stats/Vector.fs | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes #312
Description
There are few shenanigans with
FSharp.Stats.DistanceMetrics.Vector
andFSharp.Stats.DistanceMetrics
which needs to be open in a non intuitive order, please let me know if you prefer I rejig this in some way.I think one approach would be to put
RequireQualifiedAccess
for theVector
module, but would incur more impact in client code.https://learn.microsoft.com/en-us/dotnet/fsharp/style-guide/component-design-guidelines#consider-using-requirequalifiedaccess-and-carefully-apply-autoopen-attributes