fslaborg / RProvider

Access R packages from F#

http://fslab.org/RProvider/

Other

235 stars 69 forks source link

Fix for #122 #124

Closed damageboy closed 10 years ago

damageboy commented 10 years ago

This is a fix for #122 Always use original location instead of shadow-copied location when loading RProvider plugins. @jack-pappas wrote the original fix, but didn't fix the RInteropClient, so I took his pull request and redid in for RInteropClient as well.

If I know how to add to jack's pull-req as myself, I would do that, instead I simply pulled his req and amended it.

damageboy commented 10 years ago

This is instead of #123 which was incomplete... Tested to work...

damageboy commented 10 years ago

Could anyone merge this?

tpetricek commented 10 years ago

I'll do it (and release the new version), but give me 2 days, a bit busy at the moment :-). There are other packages that need to be updated once new version is released (Deedle, FsLab), so this is a bit painful.

damageboy commented 10 years ago

Ah, no pressure at all, just wanted to make sure it's ok/acceptable and that someone will eventually do it... Sorry if I added pressure

damageboy commented 10 years ago

Ping?

125 is really fixed by this

tpetricek commented 10 years ago

Thanks for looking into this and contributing a neat pull request! I just tested this on my machine (works fine) and merged the pull request.