search

fslaborg / RProvider

Access R packages from F#
http://fslab.org/RProvider/
Other
235 stars 69 forks source link

Load correct dependencies in RProvider.fsx (fix #166) #167

Closed tpetricek closed 8 years ago

tpetricek commented 8 years ago

Our build.fsx script was not replacing the versions properly - it only did that for the RProvider package (which is not needed anymore, because we reference files from there directly!) but it did not generate correct references for dependencies.

This does not affect FsLab or Paket users, but it would be nice to fix this for those using R provider directly via NuGet.

tpetricek commented 8 years ago

After the changes, it still did not run on Mac - it seems that RDotNet fails to initialize REngine when we set the environment variables and then pass it null as a DLL path.

The second checkin changes how this is handled so that we find the DLL path ourselves (we did this already to check whether it exists) and then passes the DLL path to R.NET.

I released an alpha version on NuGet so that @evelinag can test it on Mac, but it certainly needs more testing.

evelinag commented 8 years ago

After the changes, the alpha version works on a Mac (I tested it on two machines running El Capitan).

The only problem is that it works only when the editor is launched from the command line because otherwise RProvider doesn't have access to $PATH and because of this it can't find R. This seems to be a "feature" introduced in El Capitan (for example see similar issues in https://github.com/ionide/ionide-fsharp/issues/155 or https://github.com/atom-community/linter/issues/726). Would it be possible to add R_HOME into ~/.rprovider.conf along with MONO64?

tpetricek commented 8 years ago

@hmansell @dcharbon @adamklein This seems to be causing issues to other people too. Can you please review the changes?

adamklein commented 8 years ago

Seems fine to me but maybe @hmansell wants to have a quick look?

hmansell commented 8 years ago

Looks OK to me (but I haven't tested it)

tpetricek commented 8 years ago

Merging this - I also updated R.NET to address #169.