search

fslaborg / RProvider

Access R packages from F#
http://fslab.org/RProvider/
Other
235 stars 69 forks source link

Get CI etc working again #213

Closed dsyme closed 2 years ago

dsyme commented 2 years ago
dsyme commented 2 years ago

@AndrewIOM We have test failures in CI, presumably because R is not installed :)

Error: /home/runner/work/RProvider/RProvider/tests/Test.RProvider/Test.fs(102,60): error FS0039: The type 'R' does not define the field, constructor or member 'data_frame'. [/home/runner/work/RProvider/RProvider/tests/Test.RProvider/Test.RProvider.fsproj]
Error: /home/runner/work/RProvider/RProvider/tests/Test.RProvider/Test.fs(103,25): error FS0072: Lookup on object of indeterminate type based on information prior to this program point. A type annotation may be needed prior to this program point to constrain the type of the object. This may allow the lookup to be resolved. [/home/runner/work/RProvider/RProvider/tests/Test.RProvider/Test.RProvider.fsproj]
Error: /home/runner/work/RProvider/RProvider/tests/Test.RProvider/Test.fs(135,18): error FS0039: The type 'R' does not define the field, constructor or member 'as_factor'. [/home/runner/work/RProvider/RProvider/tests/Test.RProvider/Test.RProvider.fsproj]
Error: /home/runner/work/RProvider/RProvider/tests/Test.RProvider/Test.fs(136,35): error FS0072: Lookup on object of indeterminate type based on information prior to this program point. A type annotation may be needed prior to this program point to constrain the type of the object. This may allow the lookup to be resolved. [/home/runner/work/RProvider/RProvider/tests/Test.RProvider/Test.RProvider.fsproj]
dsyme commented 2 years ago

@zyzhu So it turns out r-base is already pre-installed on GitHub actions Linux (I presume Windows too)

Perhaps we need to actually install some R packages though. Not sure

zyzhu commented 2 years ago

The above errors is from not setting environment variable R_HOME so that R.Net cannot locate R.

For instance, on Windows I set R_HOME to be C:\Program Files\R\4.1.0\. Don't know what's the location to set on GitHub action.

dsyme commented 2 years ago

@zyzhu @AndrewIOM I won't be able to progress this further in the next week or so, please continue to do anything you think is needed to get these addressed :)

AndrewIOM commented 2 years ago

@dsyme Something you can help with?

Pushing RProvider.2.0.0-beta.nupkg to 'https://www.nuget.org/api/v2/package'... PUT https://www.nuget.org/api/v2/package/ Forbidden https://www.nuget.org/api/v2/package/ 253ms error: Response status code does not indicate success: 403 (The specified API key is invalid, has expired, or does not have permission to access the specified package.).

nhirschey commented 2 years ago

@AndrewIOM is nuget CI still a problem? If so i can help with the nuget action. I’ve done this CI workflow with fsharp.data.toolbox and succeeded in pushing multiple versioned betas (beta.1, beta.2, etc).

This looks like the nuget key is expired. My recollection is they only last 1 year. Is the nuget api key set as a GitHub secret as in my screenshot in #216?

AndrewIOM commented 2 years ago

Hi @nhirschey thanks. I published a package manually through nuget.org so we could get testing while this was being fixed. As you say, I think we just need the nuget key set in secrets as in #216, but I do not have access to set secrets on this repository or the fslab organisation. Hopefully then the action should 'just work'!

dsyme commented 2 years ago

I've added the NUGETKEY secret to the repo

I think we can close this once master is green

AndrewIOM commented 2 years ago

Closing as builds working with Github Actions macOS and Ubuntu