The probing locations used for plugins currently does not work. There is an associated issue that in some circumstances (e.g. using nuget package from class library project) the ConfigurationManager dll fails to resolve.
This change removes ConfigurationManager dependency, which fixes runtime issues locating the .config file. It also ensures that the .config file location can be found from the single-file server executables, as well as the RProvider client part.
I have tested this with a local copy of the Deedle R plugin, which works perfectly. I am about to submit the .net 5 version of this plugin as a draft PR to the Deedle repo. Fixes #234
Types of changes
What types of changes does your code introduce to RProvider?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[x] Build and tests pass locally
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)
Proposed Changes
The probing locations used for plugins currently does not work. There is an associated issue that in some circumstances (e.g. using nuget package from class library project) the ConfigurationManager dll fails to resolve.
This change removes ConfigurationManager dependency, which fixes runtime issues locating the .config file. It also ensures that the .config file location can be found from the single-file server executables, as well as the RProvider client part.
I have tested this with a local copy of the Deedle R plugin, which works perfectly. I am about to submit the .net 5 version of this plugin as a draft PR to the Deedle repo. Fixes #234
Types of changes
What types of changes does your code introduce to RProvider? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
See Deedle in action...