Closed nhirschey closed 2 years ago
Thanks - this looks great. I agree that we can get away with this breaking change in a 2.0.2 or similar release, since 2.0 is such a big change anyway. I'll merge this.
It could also be argued that this is a bug fix, as we state that all R names with dots in general are replaced by underscores in the docs.
Proposed Changes
Fixes #226. Specifically, in packages like
data.table
the package name should have an underscore rather than a period for consistency.Types of changes
Technically a breaking change but given 2.0 is just released I think it is reasonable to include.
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
With the new functionality intellisense on
open
statements works as one would expect when trying to finddata.table
(before the change it would showdata
only, see the raised issue):Here's output from interactive: