fslaborg / RProvider

Access R packages from F#
http://fslab.org/RProvider/
Other
235 stars 69 forks source link

Floats pass to R with . rather than , in locales that use comma seperators #258

Closed AndrewIOM closed 1 year ago

AndrewIOM commented 2 years ago

Proposed Changes

Fixes bugs #186 and #79. Makes conversion from obj to float use an invariant culture when passing args to R.

Types of changes

What types of changes does your code introduce to RProvider? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

Added tests but they passed regardless of this fix, as the problem arises at design-time.