search

fslaborg / flips

Fsharp LInear Programming System
https://flipslibrary.com/#/
MIT License
253 stars 32 forks source link

Fix for stack overflow in LinearExpression.GetHashCode #142

Closed TysonMN closed 3 years ago

TysonMN commented 3 years ago

Fixes #132

...or at least I think it does. I have not been able to confirm this.

This PR contains two commits. The first commit adds a test that I was able to confirm reproduces the problem (the second line...wasn't able to confirm that first line also reproduces the issue). The second commit presumably fixes the issue, but I was not able to confirm this.

My inability to confirm is due to inconsistent compilation results. If someone else is able to that the test fails on the first commit (just to double check for good measure) and passes on the second commit, that would be greatly appreciated.

TysonMN commented 3 years ago

Ah, the automated build confirmed that the test passes. Excellent.