search

fslaborg / flips

Fsharp LInear Programming System
https://flipslibrary.com/#/
MIT License
251 stars 32 forks source link

Code clean up 2020-12-30 #147

Closed TysonMN closed 3 years ago

TysonMN commented 3 years ago

I am diving deeper into the code now trying to gain an understanding. While I am in the neighborhood, I try to simplify the code.

I tried to make many small commits both so that it is easier to statically review and verify that I am preserving behavior and to more easily find a mistake if I made one.

I know that some of the changes I made are subjective, so please feel free change anything back or even ask me to do so.

matthewcrews commented 3 years ago

I'm looking over this now. So far I don't see any problems. The thing I'm most sensitive to is stack overflows since that is really easy to mess up.

TysonMN commented 3 years ago

The thing I'm most sensitive to is stack overflows since that is really easy to mess up.

Haha! I almost did that 😟 Luckily I noticed my mistake 😅