search

fslaborg / flips

Fsharp LInear Programming System
https://flipslibrary.com/#/
MIT License
251 stars 32 forks source link

LinearExpression.Evaluate is incorrect #153

Closed matthewcrews closed 3 years ago

matthewcrews commented 3 years ago

This line is incorrect in the LinearExpression.Evaluate function:

https://github.com/fslaborg/flips/blob/f4df21504d015b13a837fa2f7f902c7ea0411e96/Flips/Types.fs#L236

TysonMN commented 3 years ago

This was fixed by PR #151, right?

TysonMN commented 3 years ago

Oh, I understand now. Both LinearExpression.Reduce and LinearExpression.Evaluate contained the same (syntactic) mistake. PR #151 fixed the mistake in LinearExpression.Reduce. The make still exists in LinearExpression.Evaluate. I hadn't noticed the problem in LinearExpression.Reduce. I created issue #148 about LinearExpression.Evaluate.