search

fslaborg / flips

Fsharp LInear Programming System
https://flipslibrary.com/#/
MIT License
251 stars 32 forks source link

Update OPTANO.Modeling to 3.9.2.537 (latest) #182

Closed brianrourkeboll closed 2 years ago

brianrourkeboll commented 2 years ago

This version of OPTANO.Modeling includes a fix to the null reference exception bug introduced in OPTANO.Modeling 3.8.1.532 (which was itself referenced in #178 in an effort to fix a different OPTANO bug).

matthewcrews commented 2 years ago

I'll get this taken care of this evening

matthewcrews commented 2 years ago

@brianrourkeboll New version has been uploaded to NuGet. You should see it shortly.

brianrourkeboll commented 2 years ago

@matthewcrews It does look like 2.4.7 somehow changed the package's FSharp.Core dependency to be (= 5.0.0) instead of (≥ 5.0.1). I'm not sure whether that was due to the update to paket.lock made in this PR or, possibly, the way 2.4.7 was built/packaged.

For my update I just ran dotnet paket update OPTANO.Modeling. I don't think I see anything in the diff to paket.lock above that would cause that change.

matthewcrews commented 2 years ago

@brianrourkeboll I'll get this fixed this evening. My apologies for the issue. I had some other things to fix as well.

Fake is not as up-to-date as Paket so that was likely the issue.

matthewcrews commented 2 years ago

New issue created to track this: https://github.com/fslaborg/flips/issues/183

brianrourkeboll commented 2 years ago

@matthewcrews No worries! It builds and runs fine with FSharp.Core 6.0.1 in practice—there's just a NU1608 warning on restore.

matthewcrews commented 2 years ago

Yeah, still drives me crazy though. I like changing warnings into errors in the compiler settings so this definitely feels like a step backward 😂