Annotation of pgn game with static eval doesn't work for me

fsmosca / chess-artist

A python script that can annotate chess games in pgn file with static evaluation or search score of an engine, can annotate an epd file with acd, acs, bm, and ce opcodes, can test engine with epd test suite and can generate chess puzzles.

GNU General Public License v3.0

69 stars 18 forks source link

Annotation of pgn game with static eval doesn't work for me #41

Closed alxlk closed 5 years ago

alxlk commented 5 years ago

It outputs a pgn with no comments like this:


[Event "?"]
[Site "?"]
[Date "2019.03.12"]
[Round "1"]
[White "lc0"]
[Black "lc0"]
[Result "1-0"]
[FEN "8/8/8/4K3/4Q3/8/8/2k5 w - - 0 1"]
[SetUp "1"]
[Annotator "Brainfish 250319 64 POPCNT"]

{Move comments are from engine static evaluation.}
1. Qe2 Kb1 2. Kd4 Kc1 
3. Kc3 Kb1 4. Qb2# 1-0

alxlk commented 5 years ago

I found the issue! On line 826 I changed 'Total Evaluation: ' to 'Total evaluation: '

fsmosca commented 5 years ago

I saw you submitted a PR.

Could you revise your patch like this.

if 'total evaluation' in line.lower():
    ...

This way Total Evaluation and Total evaluation will be considered.

fsmosca commented 5 years ago

Thanks for the PR.