fsobolev / timeswitch

Power off, reboot, suspend, send a notification or execute any command on timer. ⏲️ Written in Python using LibAdwaita.
https://flathub.org/apps/details/io.github.fsobolev.TimeSwitch
Other
36 stars 8 forks source link

Minor improvements #29

Closed plasmus777 closed 1 year ago

plasmus777 commented 1 year ago
plasmus777 commented 1 year ago

The commit https://github.com/fsobolev/timeswitch/pull/29/commits/7878995375727f8d60d4c9a5eb990e1dc2d64c57 also makes the README.md a little easier to read as well

fsobolev commented 1 year ago

LGTM. If you're done, I will merge this

plasmus777 commented 1 year ago

Hello there! I have decided to address all comments in one:

-> The Gio being added was indeed a blunder from testing;

-> Regarding the README file:

For now, I sent a commit reverting the changes to the README file, but I will still try to improve it within the scope of my fork. Feel free to use any of the changes if they are of interest. Thanks for all the commentary as well, it is quite valuable for learning purposes/improving.

fsobolev commented 1 year ago
  • One of the objectives for the Flathub/Matrix icons is to direct the viewer towards the websites, so increasing the size of the icons makes sense (adjustments are welcome);
  • Another change was the page's layout, since there are about three lines of empty space - which could be used for adding relevant information (such as contributing, releases, instructions, ...) - and centralizing images for easier viewing;
  • For mobile, the current page does not look too great either due to image sizes, but that can also be worked on.

These are good points. I will think on improving Readme later. Thanks for your suggestions! 😊

fsobolev commented 1 year ago

You almost read out what I had in mind. I'm not at home now, so I can't edit readme rn, but I will merge your changes and edit it later.

The app is built for GNOME using GTK4 and LibAdwaita, but it works under any desktop environment thanks to the flatpak technology.

While this statement is true, the reason why I noted that the app works in any DE is because I explicitly made it DE-agnostic (except for the UI). You can notice in actions.py that the app performs different dbus calls depending on whether it's running in GNOME or not. So if for example a KDE user will open an issue about something not working, I will concern it a bug and will fix it. So the goal was to let people know that the app is really expected to work in any DE. But as I said, I will merge it as it is now and will edit myself later. I need to add some things anyway before I will apply the app for Circle (I think it's ready). Thank you! :heart: