search

fsolt / dotwhisker

Dot-and-Whisker Plots of Regression Results
https://fsolt.org/dotwhisker/
Other
60 stars 10 forks source link

Error from CRAN #116

Open sammo3182 opened 1 month ago

sammo3182 commented 1 month ago

https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/dotwhisker-00check.html

using R Under development (unstable) (2024-09-01 r87083) using platform: x86_64-pc-linux-gnu R was compiled by gcc-14 (Debian 14.2.0-3) 14.2.0 GNU Fortran (Debian 14.2.0-3) 14.2.0 running under: Debian GNU/Linux trixie/sid using session charset: UTF-8 checking for file ‘dotwhisker/DESCRIPTION’ ... OK checking extension type ... Package this is package ‘dotwhisker’ version ‘0.8.2’ package encoding: UTF-8 checking package namespace information ... OK checking package dependencies ... OK checking if this is a source package ... OK checking if there is a namespace ... OK checking for executable files ... OK checking for hidden files and directories ... OK checking for portable file names ... OK checking for sufficient/correct file permissions ... OK checking serialization versions ... OK checking whether package ‘dotwhisker’ can be installed ... OK See the install log for details. checking package directory ... OK checking for future file timestamps ... OK checking ‘build’ directory ... OK checking DESCRIPTION meta-information ... OK checking top-level files ... OK checking for left-over files ... OK checking index information ... OK checking package subdirectories ... OK checking code files for non-ASCII characters ... OK checking R files for syntax errors ... OK checking whether the package can be loaded ... [3s/3s] OK checking whether the package can be loaded with stated dependencies ... [2s/2s] OK checking whether the package can be unloaded cleanly ... [2s/2s] OK checking whether the namespace can be loaded with stated dependencies ... [2s/2s] OK checking whether the namespace can be unloaded cleanly ... [2s/2s] OK checking loading without being on the library search path ... [1s/1s] OK checking use of S3 registration ... OK checking dependencies in R code ... OK checking S3 generic/method consistency ... OK checking replacement functions ... OK checking foreign function calls ... OK checking R code for possible problems ... [12s/16s] OK checking Rd files ... [0s/0s] OK checking Rd metadata ... OK checking Rd line widths ... OK checking Rd cross-references ... OK checking for missing documentation entries ... OK checking for code/documentation mismatches ... OK checking Rd \usage sections ... OK checking Rd contents ... OK checking for unstated dependencies in examples ... OK checking installed files from ‘inst/doc’ ... OK checking files in ‘vignettes’ ... OK checking examples ... [5s/6s] ERROR Running examples in ‘dotwhisker-Ex.R’ failed The error most likely occurred in:

base::assign(".ptime", proc.time(), pos = "CheckExEnv")

Name: small_multiple

Title: Generate a 'Small Multiple' Plot of Regression Results

Aliases: small_multiple

** Examples

library(broom) library(dplyr)

Attaching package: ‘dplyr’

The following objects are masked from ‘package:stats’:

filter, lag

The following objects are masked from ‘package:base’:

intersect, setdiff, setequal, union

Generate a tidy data frame of regression results from six models

m <- list() ordered_vars <- c("wt", "cyl", "disp", "hp", "gear", "am") m[[1]] <- lm(mpg ~ wt, data = mtcars) m123456_df <- m[[1]] %>% tidy %>% by_2sd(mtcars) %>%

  • mutate(model = "Model 1")

for (i in 2:6) {

  • m[[i]] <- update(m[[i-1]], paste(". ~ . +", ordered_vars[i]))
  • m123456_df <- rbind(m123456_df, m[[i]] %>% tidy %>% by_2sd(mtcars) %>%
  • mutate(model = paste("Model", i)))
  • }

Generate a 'small multiple' plot

small_multiple(m123456_df) Error in $<-.data.frame(*tmp*, "x_ind", value = c(1L, 1L, 1L, 1L, : replacement has 36 rows, data has 37 Calls: small_multiple -> $<- -> $<-.data.frame Execution halted checking for unstated dependencies in vignettes ... OK checking package vignettes ... OK checking re-building of vignette outputs ... [18s/27s] ERROR Error(s) in re-building vignettes: ... --- re-building ‘dotwhisker-vignette.Rmd’ using rmarkdown ** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/dotwhisker-vignette_files/figure-html/basic-1.png 288x288 pixels, 8 bits/pixel, 255 colors in palette Input IDAT size = 2121 bytes Input file size = 2976 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 1854 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 1854

Output IDAT size = 1854 bytes (267 bytes decrease) Output file size = 2709 bytes (267 bytes = 8.97% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/dotwhisker-vignette_files/figure-html/ci-1.png 288x288 pixels, 8 bits/pixel, 253 colors in palette Input IDAT size = 2458 bytes Input file size = 3307 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 1927 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 1927

Output IDAT size = 1927 bytes (531 bytes decrease) Output file size = 2776 bytes (531 bytes = 16.06% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/dotwhisker-vignette_files/figure-html/multipleModels-1.png 288x288 pixels, 3x8 bits/pixel, RGB Input IDAT size = 11194 bytes Input file size = 11284 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 8025 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 8025

Output IDAT size = 8025 bytes (3169 bytes decrease) Output file size = 8103 bytes (3181 bytes = 28.19% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/dotwhisker-vignette_files/figure-html/intercept-1.png 288x288 pixels, 3x8 bits/pixel, RGB Input IDAT size = 11006 bytes Input file size = 11096 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 8248 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 8248

Output IDAT size = 8248 bytes (2758 bytes decrease) Output file size = 8326 bytes (2770 bytes = 24.96% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/dotwhisker-vignette_files/figure-html/ggplot-1.png 288x288 pixels, 3x8 bits/pixel, RGB Input IDAT size = 9152 bytes Input file size = 9242 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 6821 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 6821

Output IDAT size = 6821 bytes (2331 bytes decrease) Output file size = 6899 bytes (2343 bytes = 25.35% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/dotwhisker-vignette_files/figure-html/tidyData-1.png 288x288 pixels, 8 bits/pixel, 254 colors in palette Input IDAT size = 2126 bytes Input file size = 2978 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 1866 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 1866

Output IDAT size = 1866 bytes (260 bytes decrease) Output file size = 2718 bytes (260 bytes = 8.73% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/dotwhisker-vignette_files/figure-html/tidy-1.png 288x288 pixels, 3x8 bits/pixel, RGB Input IDAT size = 10170 bytes Input file size = 10260 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 7144 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 7144

Output IDAT size = 7144 bytes (3026 bytes decrease) Output file size = 7222 bytes (3038 bytes = 29.61% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/dotwhisker-vignette_files/figure-html/regularExpression-1.png 288x288 pixels, 8 bits/pixel, 242 colors in palette Input IDAT size = 2369 bytes Input file size = 3185 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 1694 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 1694

Output IDAT size = 1694 bytes (675 bytes decrease) Output file size = 2510 bytes (675 bytes = 21.19% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/dotwhisker-vignette_files/figure-html/relabel-1.png 288x288 pixels, 8 bits/pixel, 228 colors in palette Reducing image to 8 bits/pixel, grayscale Input IDAT size = 3349 bytes Input file size = 4123 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 2992 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 2992

Output IDAT size = 2992 bytes (357 bytes decrease) Output file size = 3070 bytes (1053 bytes = 25.54% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/dotwhisker-vignette_files/figure-html/custom-1.png 288x288 pixels, 8 bits/pixel, 233 colors in palette Reducing image to 8 bits/pixel, grayscale Input IDAT size = 3394 bytes Input file size = 4183 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 3042 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 3042

Output IDAT size = 3042 bytes (352 bytes decrease) Output file size = 3120 bytes (1063 bytes = 25.41% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/dotwhisker-vignette_files/figure-html/clm-1.png 288x288 pixels, 3x8 bits/pixel, RGB Input IDAT size = 4908 bytes Input file size = 4986 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 3659 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 3659

Output IDAT size = 3659 bytes (1249 bytes decrease) Output file size = 3737 bytes (1249 bytes = 25.05% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/dotwhisker-vignette_files/figure-html/by2sd-1.png 288x288 pixels, 3x8 bits/pixel, RGB Input IDAT size = 5566 bytes Input file size = 5644 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 4018 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 4018

Output IDAT size = 4018 bytes (1548 bytes decrease) Output file size = 4096 bytes (1548 bytes = 27.43% decrease)

Quitting from lines 273-308 [brackets] (dotwhisker-vignette.Rmd) Error: processing vignette 'dotwhisker-vignette.Rmd' failed with diagnostics: 'from' must be a finite number --- failed re-building ‘dotwhisker-vignette.Rmd’

--- re-building ‘kl2007_examples.Rmd’ using rmarkdown ** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/kl2007_examples_files/figure-html/unnamed-chunk-2-1.png 672x672 pixels, 8 bits/pixel, 256 colors in palette Reducing image to 8 bits/pixel, grayscale Input IDAT size = 21594 bytes Input file size = 22476 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 20036 zc = 9 zm = 8 zs = 1 f = 0 IDAT size = 19890 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 1 f = 0 IDAT size = 19890

Output IDAT size = 19890 bytes (1704 bytes decrease) Output file size = 19968 bytes (2508 bytes = 11.16% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/kl2007_examples_files/figure-html/unnamed-chunk-3-1.png 672x672 pixels, 3x8 bits/pixel, RGB Input IDAT size = 48668 bytes Input file size = 48806 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 38124 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 38124

Output IDAT size = 38124 bytes (10544 bytes decrease) Output file size = 38202 bytes (10604 bytes = 21.73% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/kl2007_examples_files/figure-html/unnamed-chunk-4-1.png 672x768 pixels, 8 bits/pixel, 256 colors in palette Reducing image to 8 bits/pixel, grayscale Input IDAT size = 26211 bytes Input file size = 27105 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 24057 zc = 9 zm = 8 zs = 1 f = 0 IDAT size = 24030 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 1 f = 0 IDAT size = 24030

Output IDAT size = 24030 bytes (2181 bytes decrease) Output file size = 24108 bytes (2997 bytes = 11.06% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/kl2007_examples_files/figure-html/unnamed-chunk-5-1.png 672x768 pixels, 3x8 bits/pixel, RGB Input IDAT size = 61554 bytes Input file size = 61716 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 47315 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 47315

Output IDAT size = 47315 bytes (14239 bytes decrease) Output file size = 47393 bytes (14323 bytes = 23.21% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/kl2007_examples_files/figure-html/unnamed-chunk-6-1.png 480x864 pixels, 8 bits/pixel, 256 colors in palette Reducing image to 8 bits/pixel, grayscale Input IDAT size = 26191 bytes Input file size = 27085 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 24023 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 24023

Output IDAT size = 24023 bytes (2168 bytes decrease) Output file size = 24101 bytes (2984 bytes = 11.02% decrease)

** Processing: /home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/dotwhisker.Rcheck/vign_test/dotwhisker/vignettes/kl2007_examples_files/figure-html/unnamed-chunk-7-1.png 384x864 pixels, 3x8 bits/pixel, RGB Input IDAT size = 65710 bytes Input file size = 65884 bytes

Trying: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 47756 zc = 9 zm = 8 zs = 1 f = 0 zc = 1 zm = 8 zs = 2 f = 0 zc = 9 zm = 8 zs = 3 f = 0 zc = 9 zm = 8 zs = 0 f = 5 zc = 9 zm = 8 zs = 1 f = 5 zc = 1 zm = 8 zs = 2 f = 5 zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters: zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 47756

Output IDAT size = 47756 bytes (17954 bytes decrease) Output file size = 47834 bytes (18050 bytes = 27.40% decrease)

--- finished re-building ‘kl2007_examples.Rmd’

SUMMARY: processing the following file failed: ‘dotwhisker-vignette.Rmd’

Error: Vignette re-building failed. Execution halted checking PDF version of manual ... [5s/7s] OK checking HTML version of manual ... [0s/0s] OK checking for non-standard things in the check directory ... OK DONE Status: 2 ERRORs

bbolker commented 1 month ago

Deadline for CRAN archiving is in two days (don't know if there is any grace period).

I started to look at what the issues were but got busy with other stuff (and the stuff that I did find was deep enough that quick fixes weren't obvious). If it would be helpful for me to keep digging/trying to solve issues, please let me know.

sammo3182 commented 1 month ago

Thank you so much for looking into the error, Ben @bbolker ! I went through the error message but still cannot figure out what caused the error. On the other hand, I passed the check under both linux and win 11 without any problem. To prevent being archived, I submitted a new minor version with a simpler version of small_multiple example. Let's see if it can go through for now.

sammo3182 commented 1 month ago

The modification of the small_multiple example does not fix anything. The new version still got the following error, while both the function and vignette worked well and passed the checks locally in my linux and win 11. Any suggestion of how to fix the problem or anything I can try would be appreciated, Ben @bbolker and Fred @fsolt 

Running examples in 'dotwhisker-Ex.R' failed
The error most likely occurred in:

> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: small_multiple
> ### Title: Generate a 'Small Multiple' Plot of Regression Results
> ### Aliases: small_multiple
> 
> ### ** Examples
> 
> 
> m1 <- lm(mpg ~ wt + cyl + disp + gear, data = mtcars)
> m2 <- update(m1, . ~ . + hp)
> 
> 
> # Generate a 'small multiple' plot
> small_multiple(list(m1, m2))
Error in `$<-.data.frame`(`*tmp*`, "x_ind", value = c(1L, 1L, 1L, 1L,  : 
  replacement has 10 rows, data has 11
Calls: small_multiple -> $<- -> $<-.data.frame
Execution halted
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes ... OK
* checking re-building of vignette outputs ... [10s] ERROR
Error(s) in re-building vignettes:
--- re-building 'dotwhisker-vignette.Rmd' using rmarkdown

Quitting from lines 273-308 [brackets] (dotwhisker-vignette.Rmd)
Error: processing vignette 'dotwhisker-vignette.Rmd' failed with diagnostics:
'from' must be a finite number
--- failed re-building 'dotwhisker-vignette.Rmd'

--- re-building 'kl2007_examples.Rmd' using rmarkdown
--- finished re-building 'kl2007_examples.Rmd'

SUMMARY: processing the following file failed:
  'dotwhisker-vignette.Rmd'

Error: Vignette re-building failed.
Execution halted
bbolker commented 1 month ago

See https://github.com/fsolt/dotwhisker/pull/117

sammo3182 commented 1 month ago

See #117

Thanks for Ben's work! CRAN asked for more documentation stuff, though:

The Description field is intended to be a (one paragraph) description of what the package does and why it may be useful. Please add more details about the package functionality and implemented methods in your Description text.

If there are references describing the methods in your package, please add these in the description field of your DESCRIPTION file in the form authors (year) authors (year, ISBN:...) or if those are not available: <[https:...]https:...> with no space after 'doi:', 'https:' and angle brackets for auto-linking. (If you want to add a title as well please put it in quotes: "Title")

Please add \value to .Rd files regarding exported methods and explain the functions results in the documentation. Please write about the structure of the output (class) and also what the output means. (If a function does not return a value, please document that too, e.g. \value{No return value, called for side effects} or similar) Missing Rd-tags: relabel_y_axis.Rd: \value

Please always make sure to reset to user's options(), working directory or par() after you changed it in examples and vignettes and demos. -> inst/doc/kl2007_examples.R e.g.: oldpar <- par(mfrow = c(1,2)) ... par(oldpar)

Please fix and resubmit.

Best, Benjamin Altmann

bbolker commented 1 month ago

These are the unfortunate outcome of dotwhisker having been archived and then (attempted to be) resurrected; it goes into the "new packages" queue, which gets more strenuously checked than updates to existing packages.

This pull request starts on those fussy details. I haven't gone through to update the roxygen docs with @return tags (→ "Value" field in Rd); it would also be possible to put the Kastiellec and Leoni, and Gelman, refs in the DESCRIPTION as requested.

Let me know if I can help further, I'm eager to get the package reinstated.