fsolt / dotwhisker

Dot-and-Whisker Plots of Regression Results
https://fsolt.org/dotwhisker/
Other
60 stars 10 forks source link

add consistency to code #29

Closed Ironholds closed 9 years ago

Ironholds commented 9 years ago

In particular this:

  1. Avoids alternating the level of indentation;
  2. Uses a consistent control flow format;
  3. Consistently uses <- rather than =
  4. Consistently uses explicit return statements, rather than a mix of explicit and implicit.

In addition:

  1. importFrom statements are used wherever possible (you're only calling two dplyr functions; loading the whole package is overkill);
  2. "depends" is bumped down to R 3.2.0 - the vast vast vast vast majority of users do not yet have 3.2.1 and cutting them out will limit your package's audience unnecessarily. I've tried it on 3.2.0 and it seems to work fine :)
fsolt commented 9 years ago

Thanks again, Oliver!