update by_2sd - Githubissues

fsolt / dotwhisker

Dot-and-Whisker Plots of Regression Results

https://fsolt.org/dotwhisker/

Other

60 stars 10 forks source link

update by_2sd #83

Closed bbolker closed 6 years ago

bbolker commented 6 years ago

This PR is a partial fix to #82; much more discussion of the issues I thought about but didn't fix is documented in the issue.

bbolker commented 6 years ago

BTW, I bumped the version number to a development version and made some not-strictly-necessary code changes that I consider improvements but you might not (sorry) ...

bbolker commented 6 years ago

by the way, this also changes the test for whether an object passed to dwplot is a list or a model from if ("coefficients" in names(x)) to if (inherits(x,"list")) (there could be other ways to do this ... I thought about using tryCatch(getS3method(...),error=function(e) NA) to see if there's an S3 method (although there is a tidy.list method that tries to guess ...) on the other hand, the test that was there wouldn't work for an optim or Cochrane.Orcutt-results list anyway ...