fsolt / dotwhisker

Dot-and-Whisker Plots of Regression Results
https://fsolt.org/dotwhisker/
Other
60 stars 10 forks source link

omit only NAs in term column #86

Closed bbolker closed 6 years ago

bbolker commented 6 years ago

dwplot does an na.omit step after matching order of term names. I assume that's done to eliminate terms that weren't matched in the specified order, but it has bad side effects for the new version of broom.mixed, which can include a group column in the tidied model that is NA for the fixed effects. This modification looks for NA values only in the term column ...

bbolker commented 6 years ago

there's a second issue here. I don't have an example, but I've made some of the dw_tidy() logic for the by_2sd=FALSE case parallel with the default by_2sd=TRUE case, avoiding the "." semantics which are said (in comments) to be fragile ...

fsolt commented 6 years ago

Thanks, Ben!