search

fsolt / ropercenter

Reproducible Data Retrieval from the Roper Center Data Archive
http://fsolt.org/ropercenter/
Other
4 stars 2 forks source link

consider fxn for working with ASCII files #4

Closed fsolt closed 6 years ago

fsolt commented 6 years ago

cf. readroper (which doesn't seem to work on the surveys I've tried)

petulla commented 6 years ago

hey -- readroper maintainer here. do you mind pointing me to the surveys it didn't work on? We've been using it here on 70s/80s surveys successfully but no doubt it needs more battle testing.

fsolt commented 6 years ago

Here's one that I couldn't get to work: USAIPOGNS1992-222054.

Anyway, would you mind taking a look at the read_ascii() fxn I wrote up y'day? I nearly wrote it up first as a PR to you, but ended up just putting it here to start. I'll still submit the PR if you're interested, then I can import it back to ropercenter.

petulla commented 6 years ago

sure, submitting the pr sounds good. ill test from there. thanks.

petulla commented 6 years ago

I see the issue on my implementation, am fixing. I've sent the latest to CRAN, should be fixed in 24-48, was just a parens in the wrong place :/