search

fsouza / fake-gcs-server

Google Cloud Storage emulator & testing library.
https://pkg.go.dev/github.com/fsouza/fake-gcs-server/fakestorage?tab=doc
BSD 2-Clause "Simplified" License
1.06k stars 209 forks source link

Support for object holds #1040

Open mar-pan opened 1 year ago

mar-pan commented 1 year ago

GCS buckets allow enabling object hold. This attribute adds additional immutability for objects. Objects with holds can't be targeted by the retention policy. Those attributes can be set on bucket and object level. Currently, fake-gcs-servers miss that functionality @fsouza WDYT about adding it? I could try to implement this in a 2/3 weeks from now

fsouza commented 1 year ago

Oh yeah, I didn't know about this feature. Shouldn't be too hard to implement. The tricky bit is having default holds per bucket, as we currently don't support bucket attributes (#1025).

mar-pan commented 1 year ago

Do you plan to implement this PR with bucket attributes preserve anytime soon?

fsouza commented 1 year ago

Not planned right now, but I can try to prioritize it in the next 10 days or so to make sure you're not blocked. Does that work for you?

mar-pan commented 1 year ago

Sure

mar-pan commented 1 year ago

Hello @fsouza were you able to work on that issue with buckets?